Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mtl parsing more robust using regex #34

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Make mtl parsing more robust using regex #34

merged 1 commit into from
Oct 15, 2024

Conversation

hartikainen
Copy link
Contributor

@hartikainen hartikainen commented Oct 15, 2024 •
edited
Loading

Now supports e.g. whitespaces in filename. Previously, a line like mtllib Simple Object.mtl\n would fail.

@hartikainen
Make mtl parsing more robust using regex
7b6e6e2 
Now supports e.g. whitespaces in filename
kevinzakka
kevinzakka approved these changes Oct 15, 2024
View reviewed changes
Copy link
Owner

@kevinzakka kevinzakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hartikainen!

@kevinzakka kevinzakka merged commit bf357e5 into kevinzakka:main Oct 15, 2024
1 of 4 checks passed
@hartikainen hartikainen deleted the kristian/main branch October 15, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinzakka kevinzakka kevinzakka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hartikainen @kevinzakka