Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve toughio.run #156

Merged
merged 11 commits into from
Nov 6, 2023
Merged

Improve toughio.run #156

merged 11 commits into from
Nov 6, 2023

Conversation

keurfonluu
Copy link
Owner

  • Added: option docker_args to pass additional arguments to docker run.
  • Added: option petsc_args to pass to PETSc.
  • Added: better error handling for executable and/or Docker.
  • Fixed: capture and display standard output in IPython console.
  • Added: option blocks to only read a selection blocks.
  • Added: method __getitem__ for toughio.Mesh that returns a subset of a mesh given a slice.

Reminders:

  • Run invoke format to make sure the code follows the style guide,
  • Add tests for new features or tests that would have caught the bug that you're fixing,
  • Write detailed docstrings for all functions, classes and/or methods,
  • If adding new functionality, unit test it and add it to the documentation.

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Files Coverage Δ
toughio/_io/input/_helpers.py 82.85% <ø> (ø)
toughio/_io/input/tough/_read.py 96.34% <96.62%> (+0.06%) ⬆️
toughio/_run.py 56.12% <23.68%> (-20.35%) ⬇️
toughio/_mesh/_mesh.py 81.93% <2.85%> (-6.61%) ⬇️

📢 Thoughts on this report? Let us know!.

@keurfonluu keurfonluu merged commit fe3b845 into master Nov 6, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant