Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and enhancements #144

Merged
merged 43 commits into from
Aug 8, 2023
Merged

Fixes and enhancements #144

merged 43 commits into from
Aug 8, 2023

Conversation

keurfonluu
Copy link
Owner

@keurfonluu keurfonluu commented Aug 8, 2023

  • Added: new function write_h5 to gather outputs in a single H5 container
  • Added: option labels_order in read_output
  • Added: support GENER file in toughio-merge
  • Added: function run to run TOUGH from a Python script
  • Added: support MINC input in MESHM block
  • Added: option space_between_values to add an additional space between entries (True by default).
  • Fixed: incorrect block TIMBC output
  • Fixed: error when writing input when center is None
  • Fixed: error when reading GENER file that ends with +++
  • Fixed: error due to coordinate precision for ISOT (fixes Floating centers precision revision #141)
  • Fixed: error when reading output written by T2WELL (fixes Parameters visualization problem (Gas saturation, XCO2aq, etc) #142)
  • Changed: lines after +++ are read as ending comments
  • Changed: better formatting to improve accuracy (e.g., 1.0e+05 -> 1.0e5)

Reminders:

  • Run invoke format to make sure the code follows the style guide,
  • Add tests for new features or tests that would have caught the bug that you're fixing,
  • Write detailed docstrings for all functions, classes and/or methods,
  • If adding new functionality, unit test it and add it to the documentation.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 82.15% and project coverage change: -0.79% ⚠️

Comparison is base (6094bb7) 91.27% compared to head (c43fc24) 90.48%.
Report is 7 commits behind head on master.

❗ Current head c43fc24 differs from pull request most recent head e987c44. Consider uploading reports for the commit e987c44 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   91.27%   90.48%   -0.79%     
==========================================
  Files          94       97       +3     
  Lines        6061     6148      +87     
==========================================
+ Hits         5532     5563      +31     
- Misses        529      585      +56     
Files Changed Coverage Δ
toughio/_cli/_extract.py 87.23% <ø> (+1.51%) ⬆️
toughio/_io/output/tecplot/__init__.py 100.00% <ø> (ø)
toughio/_run.py 12.69% <12.69%> (ø)
toughio/_io/output/_helpers.py 83.67% <60.00%> (+0.69%) ⬆️
toughio/_mesh/_mesh.py 88.54% <66.66%> (-0.03%) ⬇️
toughio/_cli/_merge.py 83.33% <72.41%> (-5.80%) ⬇️
toughio/_io/input/_helpers.py 82.85% <80.00%> (-1.52%) ⬇️
toughio/_common.py 92.68% <85.71%> (-2.97%) ⬇️
toughio/_io/h5/_write.py 92.00% <92.00%> (ø)
toughio/_io/input/tough/_write.py 93.67% <95.31%> (-0.33%) ⬇️
... and 17 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameters visualization problem (Gas saturation, XCO2aq, etc)
1 participant