chore(renaming): move taskDefaults to pluginDefaults

kestra-io · Jun 5, 2024 · 346525a · 346525a
1 parent 565776f
commit 346525a
Show file tree

Hide file tree

Showing 10 changed files with 22 additions and 22 deletions.
diff --git a/docs/data-sources/namespace.md b/docs/data-sources/namespace.md
@@ -29,6 +29,6 @@ data "kestra_namespace" "example" {
 
 - `description` (String) The namespace friendly description.
 - `id` (String) The ID of this resource.
-- `task_defaults` (String) The namespace task defaults.
+- `plugin_defaults` (String) The namespace plugin defaults.
 - `tenant_id` (String) The tenant id.
 - `variables` (String) The namespace variables.
diff --git a/docs/resources/flow.md b/docs/resources/flow.md
@@ -30,7 +30,7 @@ tasks:
     message: first {{task.id}}
     level: TRACE
 
-taskDefaults:
+pluginDefaults:
   - type: io.kestra.core.tasks.log.Log
     values:
       message: third {{flow.id}}

diff --git a/docs/resources/namespace.md b/docs/resources/namespace.md
@@ -21,7 +21,7 @@ k1: 1
 k2:
     v1: 1
 EOT
-  task_defaults = <<EOT
+  plugin_defaults = <<EOT
 - type: io.kestra.core.tasks.log.Log
   values:
     message: first {{flow.id}}
@@ -42,7 +42,7 @@ EOT
 ### Optional
 
 - `description` (String) The namespace friendly description.
-- `task_defaults` (String) The namespace task defaults in yaml string.
+- `plugin_defaults` (String) The namespace plugin defaults in yaml string.
 - `variables` (String) The namespace variables in yaml string.
 
 ### Read-Only

diff --git a/examples/resources/kestra_flow/resource.tf b/examples/resources/kestra_flow/resource.tf
@@ -15,7 +15,7 @@ tasks:
     message: first {{task.id}}
     level: TRACE
 
-taskDefaults:
+pluginDefaults:
   - type: io.kestra.core.tasks.log.Log
     values:
       message: third {{flow.id}}

diff --git a/examples/resources/kestra_namespace/resource.tf b/examples/resources/kestra_namespace/resource.tf
@@ -6,7 +6,7 @@ k1: 1
 k2:
     v1: 1
 EOT
-  task_defaults = <<EOT
+  plugin_defaults = <<EOT
 - type: io.kestra.core.tasks.log.Log
   values:
     message: first {{flow.id}}

diff --git a/internal/provider/data_source_namespace.go b/internal/provider/data_source_namespace.go
@@ -34,8 +34,8 @@ func dataSourceNamespace() *schema.Resource {
 				Type:        schema.TypeString,
 				Computed:    true,
 			},
-			"task_defaults": {
-				Description: "The namespace task defaults.",
+			"plugin_defaults": {
+				Description: "The namespace plugin defaults.",
 				Type:        schema.TypeString,
 				Computed:    true,
 			},

diff --git a/internal/provider/resource_flow_test.go b/internal/provider/resource_flow_test.go
@@ -42,7 +42,7 @@ func TestAccResourceFlow(t *testing.T) {
 						"namespace: io.kestra.terraform",
 						"tasks:",
 						"  - ${indent(4, file(\"/tmp/unit-test/t1.yml\"))}",
-						"taskDefaults:",
+						"pluginDefaults:",
 						"  - type: io.kestra.core.tasks.log.Log",
 						"    values:",
 						"      message: third {{flow.id}}",

diff --git a/internal/provider/resource_namespace.go b/internal/provider/resource_namespace.go
@@ -40,8 +40,8 @@ func resourceNamespace() *schema.Resource {
 				Optional:         true,
 				DiffSuppressFunc: isYamlEquals,
 			},
-			"task_defaults": {
-				Description:      "The namespace task defaults in yaml string.",
+			"plugin_defaults": {
+				Description:      "The namespace plugin defaults in yaml string.",
 				Type:             schema.TypeString,
 				Optional:         true,
 				DiffSuppressFunc: isYamlEquals,
@@ -106,7 +106,7 @@ func resourceNamespaceUpdate(ctx context.Context, d *schema.ResourceData, meta i
 	c := meta.(*Client)
 	var diags diag.Diagnostics
 
-	if d.HasChanges("description", "variables", "task_defaults") {
+	if d.HasChanges("description", "variables", "plugin_defaults") {
 		body, err := namespaceSchemaToApi(d)
 		if err != nil {
 			return diag.FromErr(err)

diff --git a/internal/provider/resource_namespace_test.go b/internal/provider/resource_namespace_test.go
@@ -66,7 +66,7 @@ func TestAccResourceNamespace(t *testing.T) {
 						"kestra_namespace.new", "description", "My Kestra Namespace 2",
 					),
 					resource.TestMatchResourceAttr(
-						"kestra_namespace.new", "task_defaults", regexp.MustCompile(".*format: second.*"),
+						"kestra_namespace.new", "plugin_defaults", regexp.MustCompile(".*format: second.*"),
 					),
 				),
 			},
@@ -79,7 +79,7 @@ func TestAccResourceNamespace(t *testing.T) {
 	})
 }
 
-func testAccResourceNamespace(id, description, variables, taskDefaults string) string {
+func testAccResourceNamespace(id, description, variables, pluginDefaults string) string {
 	return fmt.Sprintf(
 		`
         resource "kestra_namespace" "new" {
@@ -88,13 +88,13 @@ func testAccResourceNamespace(id, description, variables, taskDefaults string) s
             variables = <<EOT
 %s
 EOT
-            task_defaults = <<EOT
+            plugin_defaults = <<EOT
 %s
 EOT
         }`,
 		id,
 		description,
 		variables,
-		taskDefaults,
+		pluginDefaults,
 	)
 }
diff --git a/internal/provider/utils_namespace.go b/internal/provider/utils_namespace.go
@@ -18,12 +18,12 @@ func namespaceSchemaToApi(d *schema.ResourceData) (map[string]interface{}, error
 	}
 	body["variables"] = variables
 
-	var taskDefaults interface{}
-	err = yaml.Unmarshal([]byte(d.Get("task_defaults").(string)), &taskDefaults)
+	var pluginDefaults interface{}
+	err = yaml.Unmarshal([]byte(d.Get("plugin_defaults").(string)), &pluginDefaults)
 	if err != nil {
 		return nil, err
 	}
-	body["taskDefaults"] = taskDefaults
+	body["pluginDefaults"] = pluginDefaults
 
 	return body, nil
 }
@@ -61,13 +61,13 @@ func namespaceApiToSchema(r map[string]interface{}, d *schema.ResourceData, c *C
 		}
 	}
 
-	if _, ok := r["taskDefaults"]; ok {
-		toYaml, err := toYaml(r["taskDefaults"].(interface{}))
+	if _, ok := r["pluginDefaults"]; ok {
+		toYaml, err := toYaml(r["pluginDefaults"].(interface{}))
 		if err != nil {
 			return diag.FromErr(err)
 		}
 
-		if err := d.Set("task_defaults", toYaml); err != nil {
+		if err := d.Set("plugin_defaults", toYaml); err != nil {
 			return diag.FromErr(err)
 		}
 	}