Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(script): no Docker options when not using the Docker runner #92

Closed
wants to merge 1 commit into from

Conversation

yuri1969
Copy link

@yuri1969 yuri1969 commented Jan 4, 2024

What changes are being made and why?

This prevents using incompatible settings with the PROCESS runner.

Note, merging this would bring a breaking change. There might be a better way around this.

close kestra-io/kestra/issues/2132


How the changes have been QAed?

id: hello-world-docker-options
namespace: company.team
tasks:
  - id: docker-only
    type: io.kestra.plugin.scripts.shell.Commands
    runner: PROCESS # FIXME
    docker:
      image: foo
    commands:
      - echo 'bar'

@loicmathieu
Copy link
Member

Hi,
Thanks for your contribution, this is indeed the way to do such validation.

However, as you said, this would be a breaking change, we'll discuss it internally.

@loicmathieu
Copy link
Member

Hi,
So we decided to postpone a little as we're not sure if we want it to fail the validation or just add a warning, which is not yet possible with our current validation implementation.

@yuri1969
Copy link
Author

yuri1969 commented Jan 9, 2024

Understood, having OK/warning/error validation states available would be useful.

@yuri1969 yuri1969 force-pushed the docker-options-check branch from f813dc8 to 00feae8 Compare January 30, 2024 21:01
@tchiotludo tchiotludo added this to the v0.16.0 milestone Mar 15, 2024
@tchiotludo tchiotludo requested a review from loicmathieu March 15, 2024 07:38
@anna-geller
Copy link
Member

closing as it will no longer be an issue with Task Runners https://develop.kestra.io/docs/concepts/task-runners

docker property will no longer be available when using the Process task runner

Thanks so much for flagging this issue @yuri1969, it helped to shape the implementation of task runners

@yuri1969 yuri1969 deleted the docker-options-check branch April 10, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raise warning if docker property is set on Script tasks along with PROCESS runner
4 participants