feat: add support for multi-platform builds

kestra-io · Dec 20, 2024 · 45bb767 · 45bb767
1 parent 99a3ef0
commit 45bb767
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 16 deletions.
diff --git a/.github/workflows/manual.yml b/.github/workflows/manual.yml
@@ -9,9 +9,11 @@ jobs:
     outputs:
       matrix: ${{ steps.dockerfiles.outputs.matrix }}
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
       - id: dockerfiles
-        run: echo "matrix=$(ls dockerfiles-manual/ | jq -R -s -c 'split("\n")[:-1]')" >> $GITHUB_OUTPUT
+        run: echo "matrix=$(ls dockerfiles-manual/ | jq -R -s -c 'split(\"\\n\")[:-1]')" >> $GITHUB_OUTPUT
 
   ghcr:
     runs-on: ubuntu-latest
@@ -20,29 +22,36 @@ jobs:
       contents: read
       packages: write
     strategy:
-      matrix: 
+      matrix:
         image: ${{ fromJson(needs.list-dockerfiles.outputs.matrix) }}
     steps:
-      - name: checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: GHCR Login
-        uses: docker/login-action@v2
+      - name: Set up QEMU for cross-platform builds
+        uses: docker/setup-qemu-action@v3
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Login to GHCR
+        uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
-      
+
       - id: image-tag  # example output: "ghcr.io/kestra-io/pydata:latest"
         run: |
-          export IMAGE=$(basename ${{ matrix.image }} .Dockerfile)
+          IMAGE=$(basename ${{ matrix.image }} .Dockerfile)
           echo "image_url=ghcr.io/kestra-io/$IMAGE:latest" >> $GITHUB_OUTPUT
           echo "file=dockerfiles-manual/${{ matrix.image }}" >> $GITHUB_OUTPUT
-      
+
       - name: Build and push Docker image
         uses: docker/build-push-action@v4
         with:
           context: .
           push: true
           tags: ${{ steps.image-tag.outputs.image_url }}
           file: ${{ steps.image-tag.outputs.file }}
+          platforms: linux/amd64,linux/arm64
diff --git a/.github/workflows/scheduled.yml b/.github/workflows/scheduled.yml
@@ -11,9 +11,11 @@ jobs:
     outputs:
       matrix: ${{ steps.dockerfiles.outputs.matrix }}
     steps:
-      - uses: actions/checkout@v4
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
       - id: dockerfiles
-        run: echo "matrix=$(ls dockerfiles/ | jq -R -s -c 'split("\n")[:-1]')" >> $GITHUB_OUTPUT
+        run: echo "matrix=$(ls dockerfiles/ | jq -R -s -c 'split(\"\\n\")[:-1]')" >> $GITHUB_OUTPUT
 
   ghcr:
     runs-on: ubuntu-latest
@@ -25,19 +27,25 @@ jobs:
       matrix:
         image: ${{ fromJson(needs.list-dockerfiles.outputs.matrix) }}
     steps:
-      - name: checkout
+      - name: Checkout repository
         uses: actions/checkout@v4
 
-      - name: GHCR Login
-        uses: docker/login-action@v2
+      - name: Set up QEMU for cross-platform builds
+        uses: docker/setup-qemu-action@v3
+
+      - name: Set up Docker Buildx
+        uses: docker/setup-buildx-action@v3
+
+      - name: Login to GHCR
+        uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
 
       - id: image-tag  # example output: "ghcr.io/kestra-io/pydata:latest"
         run: |
-          export IMAGE=$(basename ${{ matrix.image }} .Dockerfile)
+          IMAGE=$(basename ${{ matrix.image }} .Dockerfile)
           echo "image_url=ghcr.io/kestra-io/$IMAGE:latest" >> $GITHUB_OUTPUT
           echo "file=dockerfiles/${{ matrix.image }}" >> $GITHUB_OUTPUT
 
@@ -47,4 +55,5 @@ jobs:
           context: .
           push: true
           tags: ${{ steps.image-tag.outputs.image_url }}
-          file: ${{ steps.image-tag.outputs.file }}
+          file: ${{ steps.image-tag.outputs.file }}
+          platforms: linux/amd64,linux/arm64