Fix pydantic v2 warnings related to UserGroup
#572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 26, 2024 16:57
Define and use different user models for API endpoint and fastapi-users router, i.e. different models as request schema for API request model and schema for request to `fastapi-users` router. For create user request, user needs to send `UserCreateRequest` schema as API router request and the router will use `UserCreate` schema to send the request to `fastapi-users` router. This is due to we intend to have a list of user group name strings as API router request and `UserGroup` instance as `fastapi-users` router request as `user.groups` field value. Signed-off-by: Jeny Sadadia <[email protected]>
Fix the below warnings from pydantic v2 while creating
or updating a user account with user groups:
```
kernelci-api | /home/kernelci/.local/lib/python3.11/site-packages/pydantic/main.py:390: UserWarning: Pydantic serializer warnings:
kernelci-api | Expected `str` but got `UserGroup` with value `UserGroup(id=ObjectId('64...16ad'), name='kernelci')` - serialized value may not be as expected
kernelci-api | return self.__pydantic_serializer__.to_python(
```
Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
fix-pydantic-usergroup-warnings
branch
from
514774d
to
35cdfa5
Compare
pawiecz
approved these changes
Nov 27, 2024
| Field(default=None)] | ||
| groups: List[UserGroup] = Field(default=[]) | ||
|
|
||
| @field_validator('groups') |
There was a problem hiding this comment.
It would be convenient to reuse field validators but such discussion has never been resolved
Maybe the possible approaches to this task could be explored in future
There was a problem hiding this comment.
Thanks for the input. Created #579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #560
Fix the below warnings from pydantic v2 while creating or updating a user account with user groups:
Fix the issue by defining and using different user models for API endpoint and fastapi-users router, i.e. different
models as request schema for API request model and schema for request to
fastapi-usersrouter.For create user request, user needs to send
UserCreateRequestschema as API router requestand the router will use
UserCreateschema to send the request tofastapi-usersrouter.This is due to, we intend to have a list of user group name strings as API router request and
UserGroupinstance asfastapi-usersrouter request asuser.groupsfield value.