api.main: do not reset node ownership fields #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JenySadadia
force-pushed
the
fix-node-ownership
branch
from
1f2cd5d
to
1d29b0f
Compare
|
This isn't working due to pydantic issue related to |
JenySadadia
force-pushed
the
fix-node-ownership
branch
from
1d29b0f
to
27c0e1a
Compare
On update node operation, node ownership fields shouldn't be changed such as `owner` and `submitter`. Replace pydantic v1 functions with pydantic v2 following the package upgrade. Use `model_dump` and `model_copy` instead of older version functions. Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
fix-node-ownership
branch
from
27c0e1a
to
650b119
Compare
|
The PR is ready for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #563
Depends on kernelci/kernelci-core#2738
On update node operation, node ownership fields shouldn't be changed such as
ownerandsubmitter.