kube: rename minkube as minikube #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest to hold it a bit, maybe i can add patches that it will make this solution as independent self-deploy option that can work on other kubernetes clusters, not only minikube, so it can be renamed to something selfdeploy-k8s or something |
|
No I think we need to fix this and then look for maybe consolidating things. That will be needed in the next couple of months for the production deployment milestone, for now we need to wrap up the early access stuff. |
This is about MiniKube so let's fix the typo in the directory name. Fixes: 3425d17 ("adding kubernetes manifest to test kernelci-api minikube deployment") Signed-off-by: Guillaume Tucker <[email protected]>
gctucker
force-pushed
the
minikube-rename
branch
from
869166f
to
89c4a14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about MiniKube so let's fix the typo in the directory name.
Fixes: 3425d17 ("adding kubernetes manifest to test kernelci-api minikube deployment")