Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]: Navbar Dock added on Landing Page #127

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[feature]: Navbar Dock added on Landing Page #127

wants to merge 4 commits into from

Conversation

its-me-abhishek
Copy link

  • Fixes the issue: #2381
  • Changes made:
    • Added Dock Style for the Navbar
    • Updated the Dropdown Background colors according to the guidelines
    • Rounded the icons to match the Dock borders
  • Screenshots for preview:

s1
s2

@its-me-abhishek
Copy link
Author

Signed the DCO in the latest 3 commits

@yaten2302
Copy link
Contributor

yaten2302 commented Nov 7, 2024 •
edited
Loading

@its-me-abhishek , your PR is amazing, however I think what we can do is that instead of keeping the navbar stick on loading the website, we can keep it docked by default? This can be the current state when we load the website

image

WDYT @Sonichigo @TvisharajiK ?

@its-me-abhishek
Copy link
Author

the PR is up for review @TvisharajiK , also, shall I integrate the feature suggested by @yaten2302 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@its-me-abhishek @yaten2302