Use as_deref instead of clone to write font cached face ID

kennethloeffler · Aug 5, 2024 · 6f262fd · 6f262fd
1 parent 29ced42
commit 6f262fd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/rbx_binary/src/serializer/state.rs b/rbx_binary/src/serializer/state.rs
@@ -798,7 +798,7 @@ impl<'dom, 'db, W: Write> SerializerState<'dom, 'db, W> {
                                 chunk.write_le_u16(value.weight.as_u16())?;
                                 chunk.write_u8(value.style.as_u8())?;
                                 chunk.write_string(
-                                    &value.cached_face_id.clone().unwrap_or_default(),
+                                    value.cached_face_id.as_deref().unwrap_or_default(),
                                 )?;
                             } else {
                                 return type_mismatch(i, &rbx_value, "Font");

diff --git a/rbx_types/src/attributes/writer.rs b/rbx_types/src/attributes/writer.rs
@@ -95,7 +95,7 @@ pub(crate) fn write_attributes<W: Write>(
                 write_string(&mut writer, &font.family)?;
                 write_string(
                     &mut writer,
-                    &font.cached_face_id.clone().unwrap_or_default(),
+                    font.cached_face_id.as_deref().unwrap_or_default(),
                 )?;
             }