Added ability to show both faces of the card at the same time. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work Cristian, I like it. I think would be our preferred way to display it too. Thanks for sharing. |
…d changes included. Since skeuocard basically works only for IE10+ we almost always have to provide a good no-js alternative. In order to style the inputs we will often include them in divs or other containers which will be removed by the initialisation JS. Thanks @leek for the fix. Refs kenkeiter#103 kenkeiter#101 Fixes kenkeiter#108
|
@cvrabie this is an interesting feature. Can you merge into dev instead of master? Thx! |
|
Great! Exactly what it needed! |
|
Just what I needed. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a project where the user base is skewed toward people with very little experience with computers. After doing some user testing I discovered that the only negative comment about our payment section is that not everybody understands right away that they need to flip the card (even though there's a big red/green button that says so ... i know).
I also saw a few other people make similar comments in the issues section, and a few websites like pingdom which chose to go with a two-face visual card option.
So I've made this patch that allows you to disable the flip and show both faces at the same time. It seemed to be better received by our targeted customers.
The solution is completely CSS based. You can make it work by simply adding the
two-faceclass on theskeuocardelement. Alternatively you can also specify it in the initialization parameters like thisNot sure if you're interested in merging such a feature in the main branch but here it is. Also, thank you very much for making Skeuocard available in the first place!