Android Support #19
Open
Android Support #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 23, 2017 18:00
Open
You can then open devices up from a list in the Editor Window You can CloseAllDevices in the Editor Window known issue: un-checking a device's toggle in the Editor Window does not properly close it yet.
…GetEndpointName method (this matches Windows plugin now)
|
Thank you for this! This PR didn't work for me (on Oculus Quest 2), but by adding some crude changes on top of it I was able to make it work - via the bluetooth API. See here. Anybody interested in continuing this PR, or basing some better designed API off it should probably look into state observation on bluetooth, and fix the USB MIDI connection. I had no time so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork includes support for Android 6 (Marshmallow) devices and above.
The project includes an Android Studio project for building the plugin, as well as the plugin itself. The plugin will build directly into the Assets/MidiJack/Android/Plugins folder.
I tried to make it work the same as the Windows plugin using the Dequeue system but wound up with stuck notes and incorrect buffer order issues. So I instead use a Callback system, where MidiDriver can directly register for events happening on the plugin and respond to them. It would make sense to refactor MidiDriver to have NoteOn, NoteOff, ControlChange handlers that both this callback method and the Update while() loop method could use but I didn't want to change so much of your architecture right off the bat.
This is tested and working on my Pixel, untested on any other phones but should work as I'm using OS-level MIDI functions.