Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proton Pass importer #11197

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

droidmonkey
Copy link
Member

@droidmonkey droidmonkey commented Aug 25, 2024

We will only support unencrypted json exports since Proton Pass uses PGP for encrypted exports for some reason.
We also do not support passkey exports from Proton Pass yet.

Screenshots

image

Testing strategy

Added unit tests

Type of change

  • ✅ New feature (change that adds functionality)

@droidmonkey droidmonkey added this to the v2.7.10 milestone Aug 25, 2024
Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 74.63768% with 35 lines in your changes missing coverage. Please review.

Project coverage is 63.06%. Comparing base (48d0f2b) to head (cb60486).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/gui/wizard/ImportWizardPageReview.cpp 0.00% 17 Missing ⚠️
src/format/ProtonPassReader.cpp 90.99% 10 Missing ⚠️
src/gui/wizard/ImportWizardPageSelect.cpp 0.00% 6 Missing ⚠️
src/gui/DatabaseTabWidget.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11197      +/-   ##
===========================================
+ Coverage    63.03%   63.06%   +0.03%     
===========================================
  Files          362      364       +2     
  Lines        37737    37867     +130     
===========================================
+ Hits         23786    23878      +92     
- Misses       13951    13989      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phoerious phoerious added pr: new feature Pull request that adds a new feature and removed new feature labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new feature Pull request that adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Proton Pass importer
2 participants