-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for deployment on Goerli testnet #215
base: goerli-deploy
Are you sure you want to change the base?
Conversation
Görli became a recommended test network after Ropsten's deprecation notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/). We're modifying GitHub Actions workflow for deploying `coverage-pools` contracts to support the deployment on Görli. NOTE: We're temporarily using some testing configuration in the workflow, which needs to be removed before merge to `main`.
6f5ad4f
to
de5d371
Compare
I run the deployment on
Workflow run: https://github.com/keep-network/coverage-pools/runs/7670017006?check_suite_focus=true. [EDIT]: Verified again, on a |
We use the V1's
The first argument is expected to implement ICollateralToken interface:coverage-pools/contracts/AssetPool.sol Line 133 in 7740f43
Unfortunatelly the I'm not sure what are the plans regarding the latest |
Görli became a recommended test network after Ropsten's deprecation
notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/).
We're modifying GitHub Actions workflow for deploying
coverage-pools
contracts to support the deployment on Görli.
TODO:
GOERLI_ETH_HOSTNAME_HTTP
andGOERLI_ETH_CONTRACT_OWNER_PRIVATE_KEY
secrets forcoverage-pools
repo