-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to threshold-network
and keep-network
projects
#212
base: main
Are you sure you want to change the base?
Changes from 1 commit
7bbb6f6
71f44ba
f2ad2a3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -87,12 +87,14 @@ jobs: | |||||
query: | | ||||||
keep-core-contracts-version = github.com/keep-network/keep-core/solidity-v1#version | ||||||
tbtc-contracts-version = github.com/keep-network/tbtc/solidity#version | ||||||
solidity-contracts-version = github.com/threshold-network/solidity-contracts#version | ||||||
|
||||||
- name: Resolve latest contracts | ||||||
run: | | ||||||
yarn upgrade \ | ||||||
@keep-network/keep-core@${{ steps.upstream-builds-query.outputs.keep-core-contracts-version }} \ | ||||||
@keep-network/tbtc@${{ steps.upstream-builds-query.outputs.tbtc-contracts-version }} | ||||||
@keep-network/tbtc@${{ steps.upstream-builds-query.outputs.tbtc-contracts-version }} \ | ||||||
@threshold-network/solidity-contracts@${{ steps.upstream-builds-query.outputs.solidity-contracts-version }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
- name: Configure tenderly | ||||||
if: github.event.inputs.environment == 'ropsten' | ||||||
|
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -28,7 +28,8 @@ jobs: | |||||
run: | | ||||||
yarn upgrade \ | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's pin to exact dependencies versions. (see keep-network/keep-core#3083 for explaination)
Suggested change
|
||||||
@keep-network/keep-core \ | ||||||
@keep-network/tbtc | ||||||
@keep-network/tbtc \ | ||||||
@threshold-network/solidity-contracts | ||||||
|
||||||
# Deploy contracts to a local network to generate deployment artifacts that | ||||||
# are required by dashboard compilation. | ||||||
|
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -35,10 +35,10 @@ | |||||||||
"prepublishOnly": "./scripts/prepare-artifacts.sh --network $npm_config_network" | ||||||||||
}, | ||||||||||
"dependencies": { | ||||||||||
"@keep-network/keep-core": ">1.8.0-dev <1.8.0-pre", | ||||||||||
"@keep-network/tbtc": ">1.1.2-dev <1.1.2-pre", | ||||||||||
"@keep-network/keep-core": ">1.8.0-dev <1.8.0-goerli", | ||||||||||
"@keep-network/tbtc": ">1.1.2-dev <1.1.2-goerli", | ||||||||||
Comment on lines
+38
to
+39
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we use the
Suggested change
|
||||||||||
"@thesis/solidity-contracts": "github:thesis/solidity-contracts#4985bcf", | ||||||||||
"@threshold-network/solidity-contracts": ">1.1.0-dev <1.1.0-ropsten", | ||||||||||
"@threshold-network/solidity-contracts": ">1.2.0-dev <1.2.0-goerli", | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we use
Suggested change
Same for other dependencies. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||||||
"@openzeppelin/contracts": "^4.3", | ||||||||||
"@tenderly/hardhat-tenderly": "^1.0.12" | ||||||||||
}, | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.