Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Docker credential helpers #789

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ldx
Copy link

@ldx ldx commented Dec 23, 2024

This PR adds the ability to use existing Docker credential helpers (like docker-credential-ecr-login, docker-credential-gcr, etc.) for registry authentication. This enables Keel to leverage the same credential management tools that users already have configured in their Docker environments, instead of re-implementing registry credential helpers in Keel itself.

I used the same helper registration method as in the aws and gcr helpers. The only input the new helper needs is the name of an executable that implements the Docker credential protocol (registry name is supplied via stdin, and a command line argument get is added when executing the program). The executable name is passed in via the DOCKER_CREDENTIALS_HELPER environment variable (and can be just the name of the executable without the full path).

The main use case for me was adding Azure ACR support without hacks or implementing an ACR-specific extension, and leveraging https://github.com/chrismellard/docker-credential-acr-env instead, together with Keel polling the registry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant