Skip to content

Commit

Permalink
Bump packages versions in go.mod
Browse files Browse the repository at this point in the history
* Bump versions in go.mod
* Use new version of docker/distribution under new path
* Fix failing TestOCIDigest due to upstream change
---------

Authored by: Jessica Ng <[email protected]>
  • Loading branch information
david-garcia-garcia authored Dec 10, 2024
1 parent 611ff29 commit 45df99b
Show file tree
Hide file tree
Showing 12 changed files with 435 additions and 409 deletions.
4 changes: 2 additions & 2 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@ workspace:

steps:
- name: unit-test
image: golang:1.22.8
image: golang:1.23.4
commands:
- make test

- name: build
image: golang:1.22.8
image: golang:1.23.4
commands:
- make install

Expand Down
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,6 @@ hack/deployment-norbac-helm.yaml
.idea/
tests.out
envsettings.ps1
serviceaccount/*
serviceaccount/*
cmd/keel/keel.exe
test_results.xml
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.8
FROM golang:1.23.4
COPY . /go/src/github.com/keel-hq/keel
WORKDIR /go/src/github.com/keel-hq/keel
RUN make install
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.debian
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.8
FROM golang:1.23.4
COPY . /go/src/github.com/keel-hq/keel
WORKDIR /go/src/github.com/keel-hq/keel
RUN make build
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.debug
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.8
FROM golang:1.23.4
COPY . /go/src/github.com/keel-hq/keel
WORKDIR /go/src/github.com/keel-hq/keel
RUN make install-debug
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.tests
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.22.8
FROM golang:1.23.4

# Install tparse and go-junit-report
RUN go install github.com/mfridman/tparse@latest && \
Expand Down
258 changes: 139 additions & 119 deletions go.mod

Large diffs are not rendered by default.

560 changes: 282 additions & 278 deletions go.sum

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion registry/docker/manifest.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import (
"net/http"
"strings"

manifestv2 "github.com/docker/distribution/manifest/schema2"
manifestv2 "github.com/distribution/distribution/v3/manifest/schema2"
"github.com/opencontainers/go-digest"
oci "github.com/opencontainers/image-spec/specs-go/v1"
)
Expand Down
2 changes: 1 addition & 1 deletion registry/docker/manifest_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"net/http/httptest"
"testing"

manifestV2 "github.com/docker/distribution/manifest/schema2"
manifestV2 "github.com/distribution/distribution/v3/manifest/schema2"
)

func TestGetDigest(t *testing.T) {
Expand Down
4 changes: 2 additions & 2 deletions registry/registry_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ func TestOCIDigest(t *testing.T) {
digest, err := client.Digest(Opts{
Registry: "https://index.docker.io",
Name: "vaultwarden/server",
Tag: "1.25.1",
Tag: "1.32.5",
})

if err != nil {
t.Errorf("error while getting digest: %s", err)
}

if digest != "sha256:dd8cf61d1997c098cc5686ef3116ca5cfef36f12192c01caa1de79a968397d4c" {
if digest != "sha256:84015c9306cc58f4be8b09c1adc62cfc3b2648b1430e9c15901482f3d870bd14" {
t.Errorf("unexpected digest: %s", digest)
}
}
Expand Down
2 changes: 1 addition & 1 deletion util/image/reference.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"strings"

// "github.com/docker/distribution/digest"
"github.com/docker/distribution/reference"
"github.com/distribution/distribution/v3/reference"
"github.com/opencontainers/go-digest"
)

Expand Down

0 comments on commit 45df99b

Please sign in to comment.