Add AWS region to the AWS Config Cache key

[maxbog]

The PR adds the AWS region to the key used by the AWS config cache

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6128

[zroubalik]

The build is broken

[maxbog]

@zroubalik I fixed the build

[zroubalik]

/run-e2e aws
Update: You can check the progress here

[zroubalik]

/run-e2e aws
Update: You can check the progress here

[maxbog]

@zroubalik Is something wrong with the e2e tests? I see they failed twice now :(

[zroubalik]

@zroubalik Is something wrong with the e2e tests? I see they failed twice now :(

yeah, issue on our side, will rerun once it is fixed

[ndlanier]

@zroubalik any updates on the e2e testing?

[JorTurFer]

/run-e2e aws
Update: You can check the progress here

[maxbog]

@JorTurFer I rebased the PR
Now the tests failed, but it looks like some random crash, can you please rerun the failing job and the e2e tests?

[JorTurFer]

/run-e2e aws
Update: You can check the progress here

[JorTurFer]

PTAL @kedacore/keda-core-contributors

[ndlanier]

Any insight into why it paniced/failed on the amd64 validation?

[ndlanier]

@JorTurFer is the validate - amd64 stage failure an issue with the action or an issue with the code changes in this pr?

[JorTurFer]

@JorTurFer is the validate - amd64 stage failure an issue with the action or an issue with the code changes in this pr?

I've triggered it again because probably it was a transient error

[JorTurFer]

@zroubalik @wozniakjan PTAL

[JorTurFer]

Do you agree?

yeah, makes sense!

[maxbog]

@JorTurFer @ThaSami please take another look

[JorTurFer]

Unit test are failing, could you take a look?

[maxbog]

Unit test are failing, could you take a look?

The failing tests are for prometheus scaler, and the error message is: "HTTP transport must be Google OAuth2"
TBH, I'm not sure how this is related to the changes in the PR.

[JorTurFer]

Prometheus scaler uses multiple auth providers, maybe the region change of the latest commit has had a side effect here:

keda/pkg/scalers/prometheus_scaler.go

Lines 96 to 128 in 68b6ca8

	// could be the case of azure managed prometheus. Try and get the round-tripper.
	// If it's not the case of azure managed prometheus, we will get both transport and err as nil and proceed assuming no auth.
	azureTransport, err := azure.TryAndGetAzureManagedPrometheusHTTPRoundTripper(logger, config.PodIdentity, config.TriggerMetadata)
	if err != nil {
	logger.V(1).Error(err, "error while init Azure Managed Prometheus client http transport")
	return nil, err
	}
	// transport should not be nil if its a case of azure managed prometheus
	if azureTransport != nil {
	httpClient.Transport = azureTransport
	}
	gcpTransport, err := gcp.GetGCPOAuth2HTTPTransport(config, httpClient.Transport, gcp.GcpScopeMonitoringRead)
	if err != nil && !errors.Is(err, gcp.ErrGoogleApplicationCrendentialsNotFound) {
	logger.V(1).Error(err, "failed to get GCP client HTTP transport (either using Google application credentials or workload identity)")
	return nil, err
	}
	if err == nil && gcpTransport != nil {
	httpClient.Transport = gcpTransport
	}
	awsTransport, err := aws.NewSigV4RoundTripper(config)
	if err != nil {
	logger.V(1).Error(err, "failed to get AWS client HTTP transport ")
	return nil, err
	}
	if err == nil && awsTransport != nil {
	httpClient.Transport = awsTransport
	}
	}

In any case, I've triggered the tests again

[JorTurFer]

Most probably it's returning an error here:

keda/pkg/scalers/prometheus_scaler.go

Lines 119 to 123 in 68b6ca8

	awsTransport, err := aws.NewSigV4RoundTripper(config)
	if err != nil {
	logger.V(1).Error(err, "failed to get AWS client HTTP transport ")
	return nil, err
	}

An error in that line will make fail the test although is GCP because it returns error and not the GCP transport

[maxbog]

Unit tests are passing now

[zroubalik]

/run-e2e aws
Update: You can check the progress here

[maxbog]

Can we merge the PR? I'd rather not be stuck in the conflict -> merge -> e2e test -> conflict death spiral ;)

[votzest]

it seems e2e tests got stuck again? otherwise can you merge this pr @zroubalik, please?

[JorTurFer]

@zroubalik @wozniakjan , PTAL

[maxbog]

@JorTurFer @zroubalik Please take a look at this PR. It's waiting for approval for 3 weeks now. The change is ready, waiting to be merged.

[zroubalik]

@maxbog there are some conflicts, please fix them and then I think we can merge this.

[maxbog]

@zroubalik done, no conflicts now