Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nsq scaler docs #1485

Merged
merged 6 commits into from
Nov 23, 2024
Merged

feat: nsq scaler docs #1485

merged 6 commits into from
Nov 23, 2024
+62 −5

Conversation

Ulminator
Copy link
Contributor

@Ulminator Ulminator commented Oct 14, 2024 •
edited
Loading

Added nsq scaler documentation for v2.16 release.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Relates to:

@Ulminator Ulminator requested a review from a team as a code owner October 14, 2024 21:09
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

  • Add your contribution to all applicable KEDA versions
  • GitHub checks are passing
  • Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

@netlify Netlify
Copy link

netlify bot commented Oct 14, 2024 •
edited
Loading

✅ Deploy Preview for keda ready!

Name Link
🔨 Latest commit 763f2d8
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/673694e3a834e4000852ee46
😎 Deploy Preview https://deploy-preview-1485--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This was referenced Oct 14, 2024
Merged
Merged
@Ulminator Ulminator force-pushed the nsq_scaler_docs branch 4 times, most recently from bdefcc5 to 9bfd393 Compare October 14, 2024 21:46
JorTurFer
JorTurFer approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @zroubalik @wozniakjan PTAL

@or-shachar or-shachar mentioned this pull request Nov 11, 2024
Open
6 tasks
JorTurFer
JorTurFer approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@JorTurFer JorTurFer merged commit b423c03 into kedacore:main Nov 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

@zroubalik zroubalik Awaiting requested review from zroubalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ulminator @zroubalik @JorTurFer