-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add apps proxy local development docs #2187
base: main
Are you sure you want to change the base?
Conversation
9665c8d
to
4b6e991
Compare
# Apps proxy Architecture Overview | ||
|
||
- Serves for data apps authentication and authorization. | ||
- Typicall usage is to perform OIDC login through some OIDC provider (e.g Microsoft login, google login etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Typicall usage is to perform OIDC login through some OIDC provider (e.g Microsoft login, google login etc.) | |
- Typicall usage is to perform OIDC login through some OIDC provider (e.g. Microsoft login, Google login etc.) |
In project directory run: | ||
|
||
``` | ||
docker compose run --rm --service-ports dev --net=my-test bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work for me:
Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "--net=my-test": executable file not found in $PATH: unknown
I'm guessing some additional setup is necessary?
Inside this bash run: | ||
|
||
``` | ||
make run-app-proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work either.
make: *** No rule to make target 'run-app-proxy'. Stop.
Looks like a typo.
make run-app-proxy | |
make run-apps-proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However make run-apps-proxy
doesn't work either:
make[1]: Entering directory '/code'
CGO_ENABLED=0 go build -v -mod mod -ldflags "-s -w" -o "./target/apps-proxy/proxy" ./cmd/apps-proxy
# cd /code; git status --porcelain
fatal: detected dubious ownership in repository at '/code'
To add an exception for this directory, call:
git config --global --add safe.directory /code
error obtaining VCS status: exit status 128
Use -buildvcs=false to disable VCS stamping.
make[1]: *** [Makefile:52: build-apps-proxy] Error 1
make[1]: Leaving directory '/code'
The suggested command git config --global --add safe.directory /code
fixed it though.
``` | ||
docker run --net=cli_default --rm \ | ||
--env DOMAIN=test.hub.keboola.local \ | ||
--env TARGET_HOST=<containerid> \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this extra step to obtain container id. It should be possible to just replace <containerid>
with this:
$(docker ps -aqf "name=dev")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I just want the containerid thing automated.
Jira: PSGO-919
Changes: