Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PST-2117 enabling the target setting for a remote dwh #124

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

PST-2117 enabling the target setting for a remote dwh #124

wants to merge 5 commits into from

Conversation

novak-ji
Copy link
Contributor

@novak-ji novak-ji marked this pull request as ready for review October 21, 2024 10:02
AdamVyborny
AdamVyborny approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@AdamVyborny AdamVyborny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, jen nějaký návrhy na minor refactoring na zvážení, pokud Ti dávají smysl.

src/Component.php Outdated Show resolved Hide resolved
src/DwhProvider/DwhLocationEnum.php Outdated Show resolved Hide resolved
@AdamVyborny
Copy link
Contributor

Takhle za mě dobrý 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamVyborny AdamVyborny AdamVyborny approved these changes

@MiroCillik MiroCillik Awaiting requested review from MiroCillik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novak-ji @AdamVyborny