Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement #393] Support multilingual label and comment in new property form #488

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

lukaskabc
Copy link
Collaborator

resolves #393

Copy link
Contributor

@ledsoft ledsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const language = useSelector(
(state: TermItState) => state.configuration.language
);
const [label, setLabel] = useState({} as MultilingualString);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer generics (useState<MultilingualString>({})) over casting, but that's a minor detail.

@ledsoft ledsoft merged commit 4ddd0f5 into kbss-cvut:development Jul 25, 2024
6 checks passed
@ledsoft ledsoft linked an issue Jul 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multilingual label and comment in new property form
2 participants