Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SAML 1 Tokens #16

Merged
merged 4 commits into from
Jan 18, 2015

Conversation

ebeigarts
Copy link
Contributor

This is based on #12 with these additions:

  • Rebased against master
  • Support saml_version to be number or string (1 or "1")
  • Support ID and AssertionID

@ebeigarts
Copy link
Contributor Author

@kbeckman any chance getting this merged in and relased to rubygems? I am already using this in production.

@kbeckman
Copy link
Owner

@ebeigarts, first of all let me thank you for your contribution... And my apologies for the delay on this.

I tested the initial pull request from @kcdragon quite extensively and could not get it to work through Azure ACS. ...and I didn't get many timely replies from that thread so I had to put it off. I haven't had the opportunity to test your PR yet, I had planned on getting around to this in February for another in-depth look.

Here's what I can do until I'm able to circle back around on this officially... I'll take this PR and build a "0.3.0-beta" gem this weekend so you can get away from pointing to your fork in the Gemfile and I'll do the official release sometime in February. I hope that will get you going... ...and thank you again for your contribution!

@ebeigarts
Copy link
Contributor Author

@kbeckman thanks, that would be great

kbeckman pushed a commit that referenced this pull request Jan 18, 2015
Add support for SAML 1 Tokens
@kbeckman kbeckman merged commit f8c1a28 into kbeckman:development Jan 18, 2015
@kbeckman
Copy link
Owner

Hi, @ebeigarts. I just pushed the 0.3.0-beta version to rubygems.org

https://rubygems.org/gems/omniauth-wsfed/versions/0.3.0.pre.beta

@ebeigarts
Copy link
Contributor Author

@kbeckman thanks

@ebeigarts
Copy link
Contributor Author

@kbeckman you released 0.3.0.pre.beta without my changes, they were merged in development branch and not in master, see https://github.com/kbeckman/omniauth-wsfed/network. What is the purpose for those two branches? most of the opensource projects just use master. It would be nice if you could also merge in #17 and release 0.3.0.rc1.

@kbeckman
Copy link
Owner

The branching structure in this project is set up according to git-flow like most other gems that follow semantic versioning. I made a mistake with the merge and will get another build to ruby gems out shortly...

As far as PR #17, this was a small change with no associated test(s). If you'd like to add the tests to spec/omniauth/strategies/wsfed/auth_request_spec.rb, I'll include it in another build. Otherwise, it will have to wait until I can get the test(s) in sometime in February.

@kbeckman
Copy link
Owner

Version 0.3.1-beta has been released - this time with your changes... Sorry for the confusion.

@ebeigarts
Copy link
Contributor Author

@kbeckman thanks, I will try to add tests for #17.

@ebeigarts ebeigarts deleted the feature-saml-1 branch July 29, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants