-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SAML 1 Tokens #16
Conversation
@kbeckman any chance getting this merged in and relased to rubygems? I am already using this in production. |
@ebeigarts, first of all let me thank you for your contribution... And my apologies for the delay on this. I tested the initial pull request from @kcdragon quite extensively and could not get it to work through Azure ACS. ...and I didn't get many timely replies from that thread so I had to put it off. I haven't had the opportunity to test your PR yet, I had planned on getting around to this in February for another in-depth look. Here's what I can do until I'm able to circle back around on this officially... I'll take this PR and build a "0.3.0-beta" gem this weekend so you can get away from pointing to your fork in the Gemfile and I'll do the official release sometime in February. I hope that will get you going... ...and thank you again for your contribution! |
@kbeckman thanks, that would be great |
Add support for SAML 1 Tokens
Hi, @ebeigarts. I just pushed the https://rubygems.org/gems/omniauth-wsfed/versions/0.3.0.pre.beta |
@kbeckman thanks |
@kbeckman you released |
The branching structure in this project is set up according to git-flow like most other gems that follow semantic versioning. I made a mistake with the merge and will get another build to ruby gems out shortly... As far as PR #17, this was a small change with no associated test(s). If you'd like to add the tests to |
Version 0.3.1-beta has been released - this time with your changes... Sorry for the confusion. |
This is based on #12 with these additions:
saml_version
to be number or string (1
or"1"
)ID
andAssertionID