Skip to content

Commit

Permalink
patch 9.0.0991: crash when reading help index with various options set
Browse files Browse the repository at this point in the history
Problem:    Crash when reading help index with various options set. (Marius
            Gedminas)
Solution:   Do not set wlv.c_extra to NUL when wlv.p_extra is NULL.
            (closes vim#11651)
  • Loading branch information
brammool committed Dec 2, 2022
1 parent c96b7f5 commit c67c89c
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 7 deletions.
16 changes: 9 additions & 7 deletions src/drawline.c
Original file line number Diff line number Diff line change
Expand Up @@ -2894,10 +2894,10 @@ win_line(
// into "ScreenLines".
if (c == TAB && (!wp->w_p_list || wp->w_lcs_chars.tab1))
{
int tab_len = 0;
long vcol_adjusted = wlv.vcol; // removed showbreak length
int tab_len = 0;
long vcol_adjusted = wlv.vcol; // removed showbreak len
#ifdef FEAT_LINEBREAK
char_u *sbr = get_showbreak_value(wp);
char_u *sbr = get_showbreak_value(wp);

// only adjust the tab_len, when at the first column
// after the showbreak value was drawn
Expand All @@ -2917,8 +2917,10 @@ win_line(
#ifdef FEAT_LINEBREAK
if (!wp->w_p_lbr || !wp->w_p_list)
#endif
{
// tab amount depends on current column
wlv.n_extra = tab_len;
}
#ifdef FEAT_LINEBREAK
else
{
Expand All @@ -2940,9 +2942,9 @@ win_line(
# endif
if (tab_len > 0)
{
// If wlv.n_extra > 0, it gives the number of
// chars, to use for a tab, else we need to
// calculate the width for a tab.
// If wlv.n_extra > 0, it gives the number of chars
// to use for a tab, else we need to calculate the
// width for a tab.
int tab2_len = mb_char2len(wp->w_lcs_chars.tab2);
len = tab_len * tab2_len;
if (wp->w_lcs_chars.tab3)
Expand Down Expand Up @@ -3018,7 +3020,7 @@ win_line(
? wp->w_lcs_chars.tab3
: wp->w_lcs_chars.tab1;
#ifdef FEAT_LINEBREAK
if (wp->w_p_lbr)
if (wp->w_p_lbr && wlv.p_extra != NULL)
wlv.c_extra = NUL; // using p_extra from above
else
#endif
Expand Down
18 changes: 18 additions & 0 deletions src/testdir/test_breakindent.vim
Original file line number Diff line number Diff line change
Expand Up @@ -1034,4 +1034,22 @@ func Test_breakindent_column()
bwipeout!
endfunc

func Test_linebreak_list()
" This was setting wlv.c_extra to NUL while wlv.p_extra is NULL
filetype plugin on
syntax enable
edit! $VIMRUNTIME/doc/index.txt
/v_P

setlocal list
setlocal listchars=tab:>-
setlocal linebreak
setlocal nowrap
setlocal filetype=help
redraw!

bwipe!
endfunc


" vim: shiftwidth=2 sts=2 expandtab
2 changes: 2 additions & 0 deletions src/version.c
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,8 @@ static char *(features[]) =

static int included_patches[] =
{ /* Add new patch number below this line */
/**/
991,
/**/
990,
/**/
Expand Down

0 comments on commit c67c89c

Please sign in to comment.