-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling DistributionNotFound exceptions #60
base: main
Are you sure you want to change the base?
Conversation
1bce184
to
23bfad6
Compare
@sezanzeb Thanks for looking into this! A flatpak built from this PR's ref launches normally again, but it shows $ flatpak run --user org.soundconverter.SoundConverter//master
ERROR: Disabling mp3-id-tags output. Do you have "gst-plugins-good" installed?
ERROR: Disabling mp3-vbr-tags output. Do you have "gst-plugins-ugly" installed?
soundconverter unknown-version and in the GUI: Is it possible to specify the version at build time? |
"unknown-version" is the fallback for this case
Yes, input-remapper does something similar with the commit hash: https://github.com/sezanzeb/input-remapper/blob/main/setup.py#L34, it writes it into a python file which is then imported during runtime. Instead of asking Or we hardcode the version number. It is hardcoded in setup.py already anyway. We just shouldn't forget to change it everywhere. |
I have no preference if you hardcode the version number or if I have to set it during packaging, but I'd prefer to have something else than "unknown version" showing up. |
This should not be necessary, but until someone can tell me what is going on here, at least this starts soundconverter again. Revisit after kassoulet/soundconverter#60 has been merged with a way to set a proper version number. Fixes flathub#6
I hope I'll find time to do this at some point, there are a lot of other things open in other projects right now |
@jmaibaum does this work for you? Is the
os.environ.get('container') == 'flatpak'
test reliable?