Skip to content

Commit

Permalink
10.08
Browse files Browse the repository at this point in the history
  • Loading branch information
kashamalasha committed Aug 10, 2023
1 parent 55a5de6 commit 20e67e3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ jobs:
run: |
security unlock-keychain -p "${{ env.KEYCHAIN_PWD }}" ${{ env.KEYCHAIN_NAME }}
xcrun notarytool store-credentials ${{ env.NOTARYTOOL_PROFILE }} \
--apple-id "${{ env.APPLE_ID }}" \
--team-id "${{ env.APPLE_TEAM_ID }}" \
--apple-id ${{ env.APPLE_ID }} \
--team-id ${{ env.APPLE_TEAM_ID }} \
--password "${{ env.APPLE_APP_SPECIFIC_PASSWORD }}" \
--keychain "${{ env.KEYCHAIN_PATH }}${{ env.KEYCHAIN_NAME }}-db"
- name: Build the artifacts and upload them on Github
env:
KEYCHAIN: "${{ env.KEYCHAIN_PATH }}${{ env.KEYCHAIN_NAME }}-db"
KEYCHAIN_PROFILE: "${{ env.NOTARYTOOL_PROFILE }}"
KEYCHAIN_PROFILE: ${{ env.NOTARYTOOL_PROFILE }}
GH_TOKEN: ${{ github.token }}
run: |
npm run ship
Expand Down
14 changes: 6 additions & 8 deletions build/notarize.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ const fs = require('fs');
const path = require('path');
const electronNotarize = require('@electron/notarize');

// module.exports = async function (context) {
module.exports = function (context) {
module.exports = async function (context) {
let params = {
tool: `notarytool`,
appPath: path.join(context.appOutDir, `${context.packager.appInfo.productFilename}.app`),
Expand Down Expand Up @@ -45,13 +44,12 @@ module.exports = function (context) {
}

console.log(`${prefix} notarizing App file at ${params.appPath}`);
console.log(context);

// try {
// await electronNotarize.notarize(params);
// } catch (error) {
// console.error(error);
// }
try {
await electronNotarize.notarize(params);
} catch (error) {
console.error(error);
}

console.log(`${prefix} done notarizing for the ${context.packager.appInfo.productFilename}.app`);
};

0 comments on commit 20e67e3

Please sign in to comment.