feat : added governance functions in proxy

.github/workflows/pull-request.yml

@@ -19,5 +19,5 @@ jobs:
 
   linters_cargo:
     name: Run Cargo linters
-    uses: ./.github/workflows/linters-cargo.yml
+    uses: ./.github/workflows/cargo-linters.yml
     needs: rust_build

README.md

@@ -2,6 +2,14 @@
 
 This repository contains interfaces and functions to interact with starknet solidity contracts.
 
+One can use two options for deploying the implementation contract :
+
+- `deploy_contract_behind_unsafe_proxy` : This will deploy the contract behind a minimal proxy
+  and can be used for dev purposes.
+
+- `deploy_contract_behind_safe_proxy` : This will deploy the contract behind a safe audited
+  proxy and setting the implementation and upgrades
+
 ## Setup
 
 ```bash

crates/l2/starkgate-manager-client/src/clients/starkgate_manager.rs

@@ -9,7 +9,7 @@ use ethers::types::Address;
 pub struct StarkgateManagerContractClient {
     manager: StarkgateManager<LocalWalletSignerMiddleware>,
     proxy_support: ProxySupport<LocalWalletSignerMiddleware>,
-    manager_implementation: StarkgateManager<LocalWalletSignerMiddleware>,
+    manager_implementation: Address,
 }
 
 impl StarkgateManagerContractClient {
@@ -21,7 +21,7 @@ impl StarkgateManagerContractClient {
         Self {
             manager: StarkgateManager::new(address, client.clone()),
             proxy_support: ProxySupport::new(address, client.clone()),
-            manager_implementation: StarkgateManager::new(implementation_address, client.clone()),
+            manager_implementation: implementation_address,
         }
     }
 }
@@ -43,7 +43,7 @@ impl StarknetContractClient for StarkgateManagerContractClient {
         self.manager.address()
     }
     fn implementation_address(&self) -> Address {
-        self.manager_implementation.address()
+        self.manager_implementation
     }
     fn client(&self) -> Arc<LocalWalletSignerMiddleware> {
         self.manager.client()

crates/l2/starkgate-registry-client/src/clients/starkgate_registry.rs

@@ -9,7 +9,7 @@ use ethers::types::Address;
 pub struct StarkgateRegistryContractClient {
     registry: StarkgateRegistry<LocalWalletSignerMiddleware>,
     proxy_support: ProxySupport<LocalWalletSignerMiddleware>,
-    registry_implementation: StarkgateRegistry<LocalWalletSignerMiddleware>,
+    registry_implementation: Address,
 }
 
 impl StarkgateRegistryContractClient {
@@ -21,7 +21,7 @@ impl StarkgateRegistryContractClient {
         Self {
             registry: StarkgateRegistry::new(address, client.clone()),
             proxy_support: ProxySupport::new(address, client.clone()),
-            registry_implementation: StarkgateRegistry::new(implementation_address, client.clone()),
+            registry_implementation: implementation_address,
         }
     }
 }
@@ -42,7 +42,7 @@ impl StarknetContractClient for StarkgateRegistryContractClient {
         self.registry.address()
     }
     fn implementation_address(&self) -> Address {
-        self.registry_implementation.address()
+        self.registry_implementation
     }
     fn client(&self) -> Arc<LocalWalletSignerMiddleware> {
         self.registry.client()

crates/l2/starknet-core-contract-client/src/clients/sovereign.rs

@@ -15,7 +15,7 @@ pub struct StarknetSovereignContractClient {
     proxy_support: ProxySupport<LocalWalletSignerMiddleware>,
     governance: StarknetGovernance<LocalWalletSignerMiddleware>,
     governed_finalizable: GovernedFinalizable<LocalWalletSignerMiddleware>,
-    core_contract_implementation: StarknetSovereignContract<LocalWalletSignerMiddleware>,
+    core_contract_implementation: Address,
 }
 
 impl StarknetSovereignContractClient {
@@ -31,10 +31,7 @@ impl StarknetSovereignContractClient {
             proxy_support: ProxySupport::new(address, client.clone()),
             governance: StarknetGovernance::new(address, client.clone()),
             governed_finalizable: GovernedFinalizable::new(address, client.clone()),
-            core_contract_implementation: StarknetSovereignContract::new(
-                implementation_address,
-                client.clone(),
-            ),
+            core_contract_implementation: implementation_address,
         }
     }
 }
@@ -77,7 +74,7 @@ impl StarknetContractClient for StarknetSovereignContractClient {
         self.core_contract.address()
     }
     fn implementation_address(&self) -> Address {
-        self.core_contract_implementation.address()
+        self.core_contract_implementation
     }
     fn client(&self) -> Arc<LocalWalletSignerMiddleware> {
         self.core_contract.client()

crates/l2/starknet-eth-bridge-client/src/clients/eth_bridge.rs

@@ -10,7 +10,7 @@ use ethers::types::Address;
 pub struct StarknetEthBridgeContractClient {
     eth_bridge: StarknetEthBridge<LocalWalletSignerMiddleware>,
     proxy_support: ProxySupport<LocalWalletSignerMiddleware>,
-    eth_bridge_implementation: StarknetEthBridge<LocalWalletSignerMiddleware>,
+    eth_bridge_implementation: Address,
 }
 
 impl StarknetEthBridgeContractClient {
@@ -22,10 +22,7 @@ impl StarknetEthBridgeContractClient {
         Self {
             eth_bridge: StarknetEthBridge::new(address, client.clone()),
             proxy_support: ProxySupport::new(address, client.clone()),
-            eth_bridge_implementation: StarknetEthBridge::new(
-                implementation_address,
-                client.clone(),
-            ),
+            eth_bridge_implementation: implementation_address,
         }
     }
 }
@@ -47,7 +44,7 @@ impl StarknetContractClient for StarknetEthBridgeContractClient {
         self.eth_bridge.address()
     }
     fn implementation_address(&self) -> Address {
-        self.eth_bridge_implementation.address()
+        self.eth_bridge_implementation
     }
     fn client(&self) -> Arc<LocalWalletSignerMiddleware> {
         self.eth_bridge.client()

crates/l2/starknet-proxy-client/src/artifacts/Proxy.json

@@ -465,4 +465,4 @@
       "type": "receive"
     }
   ]
-}
+}