Use LinkedHashSet for arrays with uniqueItems

karlvr · Aug 22, 2024 · 9603bec · 9603bec
1 parent 7d3a2fa
commit 9603bec
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/.changeset/brave-buttons-worry.md b/.changeset/brave-buttons-worry.md
@@ -0,0 +1,5 @@
+---
+"@openapi-generator-plus/java-jaxrs-generator-common": minor
+---
+
+Use `LinkedHashSet` for arrays with `uniqueItems`
diff --git a/packages/java-jaxrs-common/src/index.ts b/packages/java-jaxrs-common/src/index.ts
@@ -377,9 +377,12 @@ export default function createGenerator(config: CodegenConfig, context: JavaGene
 			const { componentNativeType, uniqueItems } = options
 			if (uniqueItems) {
 				return new context.TransformingNativeType(componentNativeType, {
-					default: (nativeType) => `java.util.List<${(nativeType.componentType || nativeType).nativeType}>`,
-					literalType: () => 'java.util.List',
-					concreteType: (nativeType) => `java.util.ArrayList<${(nativeType.componentType || nativeType).nativeType}>`,
+					/* We use LinkedHashSet everywhere to make it clear to all users of the API that it's ordered and unique.
+					   This also means we don't need to tell Jackson to use LinkedHashSet when deserializing.
+					 */
+					default: (nativeType) => `java.util.LinkedHashSet<${(nativeType.componentType || nativeType).nativeType}>`,
+					literalType: () => 'java.util.LinkedHashSet',
+					concreteType: (nativeType) => `java.util.LinkedHashSet<${(nativeType.componentType || nativeType).nativeType}>`,
 				})
 			} else {
 				return new context.TransformingNativeType(componentNativeType, {