New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parent set to null #576

Merged

lajbel merged 1 commit into kaplayjs:master from dragoncoder047:fixremove

Jan 3, 2025

Contributor

dragoncoder047 commented Dec 28, 2024

remove() / destroy() set parent to null. the parent setter would then try to add this to the children of null and crash. now it doesn't.


          Fix set parent when parent is being set to null by remove() / destroy()

2ad314e

pkg-pr-new bot commented Dec 28, 2024

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@576

commit: 2ad314e

mflerackers approved these changes

View reviewed changes

lajbel merged commit 3a5d44d into kaplayjs:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet