Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add frames list option to sprite animation #575

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: add frames list option to sprite animation #575

wants to merge 3 commits into from

Conversation

dragoncoder047
Copy link
Contributor

closes #574

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Dec 27, 2024 •
edited
Loading

Open in Stackblitz

npm i https://pkg.pr.new/kaplayjs/kaplay@575

commit: ac7ad96

@dragoncoder047
Copy link
Contributor Author

I did about 60% of the work here using GitHub Copilot. So much better than that silly Latta.ai that claimed to have solved the original issue...

niceEli
niceEli approved these changes Dec 27, 2024
View reviewed changes
Copy link
Member

@niceEli niceEli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better than lata

@dragoncoder047 dragoncoder047 marked this pull request as draft December 28, 2024 21:15
@dragoncoder047 dragoncoder047 marked this pull request as ready for review December 28, 2024 21:59
@lajbel
Copy link
Collaborator

lajbel commented Dec 30, 2024

Looking good. Add a playtest for it please

@dragoncoder047
Copy link
Contributor Author

Add a playtest for it please

ummmm would I need to add a sprite sheet or can I just reuse one?

@dragoncoder047
Copy link
Contributor Author

Looking good. Add a playtest for it please

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niceEli niceEli niceEli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
KAPLAY.js
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: frames list option for sprite animation definition
3 participants
@dragoncoder047 @lajbel @niceEli