-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/kas 2219 headers publicaties grid #868
Merged
ValenberghsSven
merged 15 commits into
development
from
feature/KAS-2219-Headers-publicaties-grid
May 11, 2021
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f04fb2f
Changed to native table
9348c89
Merge remote-tracking branch 'origin/development' into feature/KAS-22…
b868c5a
CSS voor table headers
cfe5358
Merge branch 'development' into feature/KAS-2219-Headers-publicaties-…
849afec
KAS-2219 Herwerking tabel naar nieuwe designs
4d09a60
Merge branch 'development' into feature/KAS-2219-Headers-publicaties-…
77290bd
KAS-2219 Lange namen nog aanpassen
fc78225
KAS-2219 Fixing pagination, order and css
c86a5ae
KAS-2219 van vlc naar auk
c6f4d1a
Merge remote-tracking branch 'origin/development' into feature/KAS-22…
068251e
Merge branch 'development' of https://github.com/kanselarij-vlaandere…
ValenberghsSven 293e2bc
KAS-2219 cypress test fixed
ValenberghsSven e5f1211
Merge remote-tracking branch 'origin/development' into feature/KAS-22…
2b0efa4
KAS-2219 Deleting unused css
6aa1caf
KAS-2219 Fixing new headers & order
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,7 +19,7 @@ export default class PublicationsIndexRoute extends Route { | |
as: 'sorteer', | ||
}, | ||
} | ||
|
||
params; | ||
statusFilters = Object.freeze({ // map filter name to concept uri | ||
publishedFilterOption: CONSTANTS.PUBLICATION_STATUSES.PUBLISHED, | ||
pausedFilterOption: CONSTANTS.PUBLICATION_STATUSES.PAUSED, | ||
|
@@ -34,7 +34,11 @@ export default class PublicationsIndexRoute extends Route { | |
async model(params) { | ||
const statusIds = []; | ||
let ministerFilter = {}; | ||
|
||
this.params = params; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dit lijkt me niet meer nodig nu alles weer in 1 method zit |
||
let apiSort; | ||
const filter = { | ||
':has:case': 'yes', | ||
}; | ||
for (const statusFilter of Object.keys(this.statusFilters)) { | ||
if (this.publicationFilter[statusFilter]) { | ||
const status = await this.store.findRecordByUri('publication-status', this.statusFilters[statusFilter]); | ||
|
@@ -54,23 +58,15 @@ export default class PublicationsIndexRoute extends Route { | |
}; | ||
} | ||
} | ||
|
||
const filter = { | ||
':has:case': 'yes', | ||
}; | ||
|
||
if (ministerFilter) { | ||
filter.case = ministerFilter; | ||
} | ||
|
||
if (statusIds.length > 0) { | ||
filter.status = { | ||
':id:': statusIds.join(','), | ||
}; | ||
} | ||
|
||
let apiSort; | ||
let qpSort = params.sort; | ||
let qpSort = this.params.sort; | ||
let descending; | ||
if (qpSort) { | ||
if (qpSort.startsWith('-')) { | ||
|
@@ -99,13 +95,12 @@ export default class PublicationsIndexRoute extends Route { | |
apiSort = `-${apiSort}`; | ||
} | ||
} | ||
|
||
return this.store.query('publication-flow', { | ||
filter: filter, | ||
sort: apiSort, | ||
page: { | ||
number: params.page, | ||
size: params.size, | ||
number: this.params.page, | ||
size: this.params.size, | ||
}, | ||
include: 'case,status,identification,identification.structured-identifier', | ||
}); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Van @MikiDi geleerd dat er een issue is met
@tracked
query params in de Ember versie die we momenteel gebruiken. Voor query params gebruiken we dus nog de oude Ember-manier: geen@tracked
en wijzigen viaset('page', 5)
uit@ember/object