-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ember upgrade attempt to v5.0.0 #2255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kanselarij-vlaanderen/frontend-kaleidos into feature/ember-upgrade-attempt
…elarij-vlaanderen/frontend-kaleidos into feature/ember-upgrade-attempt
…:kanselarij-vlaanderen/frontend-kaleidos into feature/ember-upgrade-attempt
ValenberghsSven
commented
Nov 25, 2024
Comment on lines
+1
to
+14
name: CI | ||
|
||
on: | ||
push: | ||
branches: | ||
- main | ||
- master | ||
pull_request: {} | ||
|
||
concurrency: | ||
group: ci-${{ github.head_ref || github.ref }} | ||
cancel-in-progress: true | ||
|
||
jobs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ember upgrade added this, do we need/want this? It's showing extra checks on github, failing on something from ember-rdfa-editor
ValenberghsSven
changed the title
Feature/ember upgrade attempt
Feature/ember upgrade attempt v5.0.0
Nov 25, 2024
ValenberghsSven
changed the title
Feature/ember upgrade attempt v5.0.0
Feature/ember upgrade attempt to v5.0.0
Nov 25, 2024
…nd-kaleidos into feature/ember-upgrade-attempt
No major breaking tests, only known flakys |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a combination of all PR's currently open that are needed to even consider ember upgrade.
Going to check if I can update ember to v5.0 with this.
Noted the steps I am taking and any errors I get (if any)
merged in the PR (conflicts resolved so everyone gets what they needed):
What did I do after merging:
relationship.meta.key
torelation.key
. It seems themeta
is no longer a thing 🤷♂️import EmberError from '@ember/error';
from modelWithModifier, no longer worked. Error still gets thrown all the same (more concurrency testing will be wise)import Store from '@ember-data/store';
was just not working, switched toimport Store from 'ember-data/store';
(no'@'
) but that might cause an issue going to v5.3.0. I tried following guides about arequestManager
but it's the same thing I got stuck on last time. it's confusing and there are no good examples of how to write custom queries with it.I had to add a linter ignore rule because of the rule
ember/use-ember-data-rfc-395-imports
Tested a bit, tried almost all routes. It seems to work ok now.
Running through jenkins/cypress to see the result.