Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ember upgrade attempt to v5.0.0 #2255

Merged
merged 14 commits into from
Nov 28, 2024

Conversation

ValenberghsSven
Copy link
Contributor

@ValenberghsSven ValenberghsSven commented Nov 25, 2024

This is a combination of all PR's currently open that are needed to even consider ember upgrade.
Going to check if I can update ember to v5.0 with this.
Noted the steps I am taking and any errors I get (if any)

merged in the PR (conflicts resolved so everyone gets what they needed):

What did I do after merging:

npm uninstall -g ember-cli    
npm install -g [email protected]
ember-cli-update --run-codemods --config config/anglebrackets-codemod-config.json
ember-cli-update upgrade --to 5.0.0
  • added the config for codemods since it tries to change all anglebrackets (like helpers) to components. It shouldn't.
  • bumped ember-power-select to next major to fix issue
  • fixed adapters using relationship.meta.key to relation.key. It seems the meta is no longer a thing 🤷‍♂️
  • removed import EmberError from '@ember/error'; from modelWithModifier, no longer worked. Error still gets thrown all the same (more concurrency testing will be wise)
  • fix polymorphism of document-type (has base model concept) to properly and explicitly indicate the relations and inverses.
  • fix store import import Store from '@ember-data/store'; was just not working, switched to import Store from 'ember-data/store'; (no '@') but that might cause an issue going to v5.3.0. I tried following guides about a requestManager but it's the same thing I got stuck on last time. it's confusing and there are no good examples of how to write custom queries with it.
    I had to add a linter ignore rule because of the rule ember/use-ember-data-rfc-395-imports

Tested a bit, tried almost all routes. It seems to work ok now.
Running through jenkins/cypress to see the result.

Comment on lines +1 to +14
name: CI

on:
push:
branches:
- main
- master
pull_request: {}

concurrency:
group: ci-${{ github.head_ref || github.ref }}
cancel-in-progress: true

jobs:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ember upgrade added this, do we need/want this? It's showing extra checks on github, failing on something from ember-rdfa-editor

@ValenberghsSven ValenberghsSven changed the title Feature/ember upgrade attempt Feature/ember upgrade attempt v5.0.0 Nov 25, 2024
@ValenberghsSven ValenberghsSven changed the title Feature/ember upgrade attempt v5.0.0 Feature/ember upgrade attempt to v5.0.0 Nov 25, 2024
@ValenberghsSven ValenberghsSven marked this pull request as ready for review November 28, 2024 15:17
@ValenberghsSven
Copy link
Contributor Author

No major breaking tests, only known flakys

@ValenberghsSven ValenberghsSven merged commit 49abad4 into development Nov 28, 2024
2 of 4 checks passed
@ValenberghsSven ValenberghsSven deleted the feature/ember-upgrade-attempt branch November 28, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant