Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing.go -> testing_test.go #50

Closed
wants to merge 1 commit into from
Closed

testing.go -> testing_test.go #50

wants to merge 1 commit into from

Conversation

winebarrel
Copy link
Member

テスト用の関数がパッケージに含まれてしまっているので、testing_test.goにリネームします

レビューをお願いします 🙏

kazukousen
kazukousen approved these changes Nov 27, 2024
View reviewed changes
Copy link

@kazukousen kazukousen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing.go ネームのまま package qg_test はできないんでしたっけ...
(そうすればパッケージからは外れるかなと...)

@winebarrel
Copy link
Member Author

testing.go ネームのまま package qg_test はできないんでしたっけ...

private fieldにアクセスしているんですよね、、、

kazukousen
kazukousen requested changes Nov 27, 2024
View reviewed changes
Copy link

@kazukousen kazukousen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

すみません、テストこけてるようでした。

@winebarrel
Copy link
Member Author

🙇
これ、変えてから気づいたのですが、動作確認用の関数っぽいので変更をやめます 🙇
お手数おかけしました

@winebarrel winebarrel closed this Nov 27, 2024
@winebarrel winebarrel deleted the renams_testing.go branch November 27, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazukousen kazukousen kazukousen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@winebarrel @kazukousen