Support Dropped Frames Metric #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
At MotorTrend, we have been using total number of dropped frames in our analytics. It would be nice to access them from PKPlaybackInfo, in Objective-C.
CheckLists
[*] changes have been done against master branch, and PR does not conflict
[*] new unit / functional tests have been added (whenever applicable)
Not sure it makes sense to add a unit test for this, since this code simply passes the value from AVPlayerItemAccessLogEvent. We would need to mock one of those objects (kinda cumbersome no?). That said, I did install the branch via Cocoapods to make sure it compiles properly. No errors on my end.
[*] test are passing in local environment
Ditto from above comment.
[*] Travis tests are passing (or test results are not worse than on master branch :))
[*] Docs have been updated
I added a comment describing what the property does