Skip to content

Commit

Permalink
Fix optional parameter declared before required parameter.
Browse files Browse the repository at this point in the history
  • Loading branch information
lucaboesch committed Aug 4, 2024
1 parent 7e7a5d6 commit 26ff213
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion mod/kalvidassign/grade_submissions.php
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
}
}

$renderer->display_submissions_table($cm, $data->group_filter, $data->filter, $data->perpage, $data->quickgrade, $tifirst, $tilast, $page);
$renderer->display_submissions_table($cm, $data->perpage, $data->group_filter, $data->filter, $data->quickgrade, $tifirst, $tilast, $page);

$prefform->set_data($data);
$prefform->display();
Expand Down
5 changes: 3 additions & 2 deletions mod/kalvidassign/renderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -706,17 +706,18 @@ public function display_instructor_buttons($cm, $userid) {

/**
* This function returns HTML markup to render a the submissions table
*
* @param object $cm A course module object.
* @param int $perpage The number of submissions to display on a page.
* @param int $groupfilter The group id to filter against.
* @param string $filter Filter users who have submitted, submitted and graded or everyone.
* @param int $perpage The number of submissions to display on a page.
* @param bool $quickgrade True if the quick grade table needs to be rendered, otherwsie false.
* @param string $tifirst The first initial of the first name.
* @param string $tilast The first initial of the last name.
* @param int $page The current page to render.
* @return string Returns HTML markup.
*/
public function display_submissions_table($cm, $groupfilter = 0, $filter = 'all', $perpage, $quickgrade = false, $tifirst = '', $tilast = '', $page = 0) {
public function display_submissions_table($cm, $perpage, $groupfilter = 0, $filter = 'all', $quickgrade = false, $tifirst = '', $tilast = '', $page = 0) {

global $DB, $COURSE, $USER;

Expand Down

0 comments on commit 26ff213

Please sign in to comment.