-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Fix security issue by upgrading ansible version #598
Conversation
ad9f54a
to
6867767
Compare
Multiple issue here. Flask testing lib: jarus/flask-testing#143
|
762f174
to
2d88018
Compare
2d88018
to
32f1031
Compare
I forced the Werkzeug version to a previous release. |
2 similar comments
I forced the Werkzeug version to a previous release. |
I forced the Werkzeug version to a previous release. |
461c64d
to
64d51c1
Compare
def __init__(self, **kwargs): | ||
super(Volume, self).__init__(**kwargs) | ||
|
||
self.level = kwargs.get('level', None) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Level expects an int
and the default value isNone
. it can lead to type incompatibility in the next linesm such as self.level - current_level
.
Maybe we could replace the default value to 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry i merged before answering. I saw that you approved.
Anyway, the level is tested in the method below. It will fail if it's not an integer. And this parameter is mandatory.
No description provided.