Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(conf): allow type coercion for configuration options #84

Merged
merged 10 commits into from
Sep 9, 2023
Merged

fix(conf): allow type coercion for configuration options #84

merged 10 commits into from
Sep 9, 2023

Conversation

ekarademir
Copy link
Collaborator

@ekarademir ekarademir commented Sep 9, 2023 •
edited
Loading

@ekarademir ekarademir merged commit 4bc43df into master Sep 9, 2023
1 check passed
@ekarademir ekarademir deleted the ertugrul/bug-fixes branch September 9, 2023 19:00
jannesarja-processmaker pushed a commit to Workfellow-Open-Source/pymongo_inmemory that referenced this pull request Aug 20, 2024
@ekarademir @jannesarja-processmaker
fix(conf): allow type coercion for configuration options (kaizendorks#84
a960794 
)

* Adds type coercion option for a configuration
* Coerces `mongod_port` to `int`, `ignore_cache` to `bool`, and `use_local_mongod` to `bool`.
* Removes unnecessary warning log for user set MongoD port since the value is advertised with context.
jannesarja-processmaker pushed a commit to Workfellow-Open-Source/pymongo_inmemory that referenced this pull request Aug 20, 2024
@ekarademir @jannesarja-processmaker
fix(conf): allow type coercion for configuration options (kaizendorks#84
d4157d2 
)

* Adds type coercion option for a configuration
* Coerces `mongod_port` to `int`, `ignore_cache` to `bool`, and `use_local_mongod` to `bool`.
* Removes unnecessary warning log for user set MongoD port since the value is advertised with context.
jannesarja-processmaker pushed a commit to Workfellow-Open-Source/pymongo_inmemory that referenced this pull request Aug 20, 2024
@ekarademir @jannesarja-processmaker
fix(conf): allow type coercion for configuration options (kaizendorks#84
5d47a50 
)

* Adds type coercion option for a configuration
* Coerces `mongod_port` to `int`, `ignore_cache` to `bool`, and `use_local_mongod` to `bool`.
* Removes unnecessary warning log for user set MongoD port since the value is advertised with context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stdout overwhelmed by port status messages in CI testing boolean environment variables not parsed correctly
1 participant
@ekarademir