BE: fixes: avro schema ser for nullable enums #685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Fixed incorrect JSON schema generation for nullable enum types in Avro schemas. Previously, nullable enums were generated with generic "enum" key instead of the actual enum name, causing incorrect serialization format with error:
400 Bad Request
json value '{"enum":"CLUBS"}' is cannot be converted to any of union types
See bug reproduction in attached video!
Is there anything you'd like reviewers to focus on?
We can think about changing nullable enums json generation. I.e. instead of :
Simply use
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
kafkaUiBug.mp4