-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves kafbat/kafka-ui#90 Added contract profile, to only build API, local profile now builds frontend #669
base: main
Are you sure you want to change the base?
Conversation
Local profile now builds frontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi KliminV! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
I think no unit tests are needed. However I would be happy to update documentation if needed |
@Haarolean could you please take a look? |
@@ -193,4 +187,25 @@ | |||
</pluginManagement> | |||
</build> | |||
|
|||
<profiles> | |||
<profile> | |||
<id>all</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would we need this all
profile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's default - to build all modules if no profile provided.
Let's confirm scope:
- we need to get rid of skipUiBuild and replace it with profile
- add frontend as part of local build
Is that all?
Then I suggest declare frontend as separate module - that allows us to avoid using properties to skip build stages
pom.xml
Outdated
</modules> | ||
</profile> | ||
<profile> | ||
<id>contract</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't quite need the contract
profile. To achieve the same one can build just one module, contract
.
What we need is a jar without the frontend, basically what skipUiBuild does now, but as a profile.
api/pom.xml
Outdated
<profile> | ||
<id>local</id> | ||
<properties> | ||
<skipUIBuild>false</skipUIBuild> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need to get rid of this property altogether replacing it with a separate profile for transparency
Added contract profil, to only build API
Local profile now builds frontend
What changes did you make? (Give an overview)
Resolves #90
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)