create reusable workflow for docker build #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapybro
bot
added
status/triage
RustamGimadiev
approved these changes
Oct 8, 2024
Haarolean
requested changes
Oct 8, 2024
| JAR_FILE=api-${{ steps.build.outputs.version }}.jar | ||
| cache-from: type=local,src=/tmp/.buildx-cache | ||
| cache-to: type=local,dest=/tmp/.buildx-cache | ||
| repository: 297478128798.dkr.ecr.eu-central-1.amazonaws.com/kafka-ui |
There was a problem hiding this comment.
Do we need this? There's already an env var ECR_REGISTRY = public.ecr.aws/s0v8j8q9
| cache-to: type=local,dest=/tmp/.buildx-cache | ||
| tag: ${{ steps.extract_branch.outputs.tag }} | ||
| version: ${{ steps.build.outputs.version }} | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} |
There was a problem hiding this comment.
This looks redundant since there's an existing secret AWS_ROLE
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: eu-central-1 | ||
| repository: ghcr.io/kafbat/kafka-ui |
There was a problem hiding this comment.
given there are aws-related properties above, this looks like it should be AWS-related, why ghcr.io?
| - name: Set up JDK | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: '17' | ||
| distribution: 'zulu' | ||
| cache: 'maven' | ||
|
|
||
| - name: Build |
There was a problem hiding this comment.
an action like this is present in 4 workflows:
build-public-imagebranch-deployreleaseseparate_env_public_create
The point of Implement reusable workflows #117 was to reduce the amount of these things, can we extract them?
|
Further user feedback is requested. Please reply within 7 days or we might close the issue. |
|
No feedback received within 7 days. Auto closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)