[Server] 서버 탈퇴 API 기능 구현 #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minisundev
reviewed
Nov 10, 2024
|
|
||
| override fun deleteMember(profile: ServerProfile) { | ||
| template.updateFirst( | ||
| query( |
There was a problem hiding this comment.
updateFirst는 해당하는 문서를 찾았으면 이후로는 더 찾지 않아서 성능에 좋기 때문에 사용하신건지 궁금합니다!!
There was a problem hiding this comment.
성능차이는 없는 걸로 알고 있습니다! serverProfile은 중복되는 것 없이, 항상 하나만 존재해야 한다는 점을 고려해 가독성과 명확성을 위해 updateFirst를 사용했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용