[User] 친구 신청 수락 API 구현 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yudonggeun
approved these changes
Jun 19, 2024
| userId: Long, | ||
| friendId: Long, | ||
| requestStatus: FriendRequestStatus, | ||
| ): Optional<Friend> |
There was a problem hiding this comment.
Optional을 사용하는 이유가 있나요? Friend? 타입을 사용하지 않고 Optional을 사용하신 이유가 궁금해요!
There was a problem hiding this comment.
수락하고자 하는 친구관계를 가져오는 과정에서 null이 반환될 경우, exception처리를 하기에 Optional을 사용하는 것이 더 깔끔한 것 같다고 판단하여 사용했습니다! Optional 사용을 지양하는 게 좋을까요,,?
Comment on lines
+18
to
+22
| fun acceptFriendRequest( | ||
| userId: Long, | ||
| friendId: Long, | ||
| ): AddFriendResponse | ||
|
|
There was a problem hiding this comment.
내부 구현을 보지 않고도 이 함수가 제공하는 기능이 무엇인지 주석을 달아주면 좋을 것 같아요.
기대하는 동작은 무엇인지 그리고 잘못된 요청을 한 케이스에 어떤 예외가 발생하는지와 같은 정보가 있으면 유지보수할 때, 좋을 것 같아요.
There was a problem hiding this comment.
넵 서비스단 메서드에 주석문 추가하도록 하겠습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용