-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cassandra 4.0.15, DSE versions 6.8.52 and 6.9.4 to build matrix #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just update the issue numbers in the Changelog and this is good to go
dse-version: [6.9.0, 6.9.1, 6.9.2, 6.9.3, 6.9.4] | ||
image-base: [jdk11] | ||
include: | ||
- dse-version: 6.9.3 | ||
- dse-version: 6.9.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment:
As of DSE 6.9.4, the k8ssandra management API is bundled in and the dse_server
images produced should work with the K8ssandra stack. Going forward, we shouldn't have to update the DSE 6.9 images any more in this project. However, I still need to figure out a testing strategy as we'll now have a small chicken-and-egg problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are those dse-server updates pushed to datastax/dse-mgmtapi-6_8 also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you mean DSE 6.8 server images, the answer is "no". Only DSE 6.9 images have the k8ssandra Management API, and only since 6.9.3. However, the 6.9.3 image that was built did not have the changes necessary for it to load the Management API agent, so it's effectively broken in that image. That was fixed in 6.9.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I mean 6.9 also. We load 6.9 images from datastax/dse-mgmtapi-6_8
repository. So we need 6.8 and 6.9 images in that repository to use them, the dse-server
repository is not used by us.
> docker run -e USE_MGMT_API=true -e MGMT_API_LISTEN_TCP_PORT=9090 -p 9090:9090 k8ssandra/cass-management-api:4.0.15 | ||
|
||
The above would run a Cassandra 4.0.14 image with Management API listening on port 9090 (instead of 8080). | ||
The above would run a Cassandra 4.0.15 image with Management API listening on port 9090 (instead of 8080). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
You don't have to change this every time. This is just a README example.
Co-authored-by: Erik Merkle <[email protected]>
Fixes #571
Fixes #569
Fixes #568