Prevent changes of DC name or both adding and removing a DC at the same time. K8OP-263 #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
force-pushed
the
feature/dcnamechangeprevention
branch
from
a6adb65 to
956754b
Compare
burmanm
reviewed
Oct 4, 2024
burmanm
reviewed
Oct 4, 2024
burmanm
reviewed
Oct 4, 2024
burmanm
reviewed
Oct 4, 2024
burmanm
reviewed
Oct 4, 2024
|
adejanovski
changed the title
|
@burmanm, could you do another round of review now that @Miles-Garnsey addressed your comments? Thanks! |
burmanm
approved these changes
Oct 4, 2024
|
I've approved due to time constraint, even if the reconcile process isn't really unit tested, but hopefully that is addressed next week. |
olim7t
reviewed
Oct 4, 2024
| @@ -172,7 +173,9 @@ func (r *K8ssandraCluster) ValidateUpdate(old runtime.Object) (admission.Warning | |||
| if err := validateUpdateNumTokens(oldCluster.Spec.Cassandra, r.Spec.Cassandra); err != nil { | |||
| return nil, err | |||
| } | |||
|
|
|||
| if DcRemoved(oldCluster.Spec, r.Spec) && DcAdded(oldCluster.Spec, r.Spec) { | |||
| return nil, fmt.Errorf("renaming, as well as adding and removing DCs at the same time is prohibited as it can cause data loss") | |||
There was a problem hiding this comment.
[nitpick] It would be nice to also include the names of the removed and added DCs.
adejanovski
pushed a commit
that referenced
this pull request
Oct 7, 2024
…me time. K8OP-263 (#1426) * Prevent changes of DC name or both adding and removing a DC at the same time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes #1422
Which issue(s) this PR fixes:
Fixes #
Checklist