Docs for data plane registration #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miles-Garnsey
force-pushed
the
docs/data-plane-registration
branch
from
9ce6375 to
853d1be
Compare
Miles-Garnsey
force-pushed
the
docs/data-plane-registration
branch
from
853d1be to
451e602
Compare
adejanovski
requested changes
May 28, 2024
| @@ -192,16 +191,6 @@ Here is a summary of what the script does: | |||
| Create a `ClientConfig` in the `kind-k8ssandra-0` cluster using the service account | |||
| token and CA cert from `kind-k8ssandra-1`: | |||
There was a problem hiding this comment.
Todo: I think lines 182 to 192 should be removed. Right?
There was a problem hiding this comment.
I don't think so actually. k8ssandra-client is doing exactly the same thing, and I personally wouldn't run it unless I had some idea of what resources it was going to manipulate.
We probably shouldn't call it a script though, maybe line 182 does need to change.
Co-authored-by: Alexander Dejanovski <[email protected]>
Miles-Garnsey
force-pushed
the
docs/data-plane-registration
branch
from
89025e6 to
1f21c13
Compare
|
adejanovski
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Document data plane registration using k8ssandra-client.
Which issue(s) this PR fixes:
Fixes #1327
Checklist