Support hcd #1319
Merged
Support hcd #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burmanm
reviewed
May 22, 2024
| return float64(256) | ||
| } | ||
| if kc.Spec.Cassandra.ServerType.IsCassandra() { |
There was a problem hiding this comment.
Isn't this breaking backwards compatibility? 16 is the default for OSS versions and all previous deployments would use that.
There was a problem hiding this comment.
you're right, and I shouldn't have touched this anyway here.
burmanm
reviewed
May 22, 2024
| @@ -10258,7 +10258,7 @@ spec: | |||
| ServerVersion is the Cassandra or DSE version. The following versions are supported: | |||
| - Cassandra: 3.11.X, 4.X.X and 5.X.X | |||
| - DSE: 6.8.X, 7.x.x | |||
| pattern: (6\.8\.\d+)|(3\.11\.\d+)|(4\.\d+\.\d+)|(5\.\d+\.\d+)|(7\.\d+\.\d+) | |||
| - HCD: 1.0.x | |||
There was a problem hiding this comment.
suggestion: We shouldn't remove pattern entirely, it should be at least something like \d+\.\d+\.\d+. We're not supporting versions like 6.9 that would auto-update to newest point-release for example.
|
@burmanm , I addressed your comments. Could you review again? |
burmanm
approved these changes
May 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for HCD as server type and remove the regex checks for server versions which already exist in cass-operator.
Fixes #1320
Checklist