move schema check to allow expansions with external DCs #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adejanovski
commented
Apr 8, 2024
| .PHONY: docker-buildx | ||
| docker-buildx: test ## Build and push docker image for the manager for cross-platform support | ||
| docker-buildx: ## Build and push docker image for the manager for cross-platform support |
There was a problem hiding this comment.
Note: I needed to build amd64 images on my M2 pro and this was not working so I fixed it in the process.
|
issue: There's no test to ensure this actually changes anything - or that some change in the future doesn't just simply revert the order and break it again. As I could go on to the next one, remove part of the code "this does nothing" and then all the tests would still pass. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Moves the schema check and replication updates before the wait for the cassdc readiness.
This prevents from being stuck in a loop where the cassdc never gets to Ready state because it cannot create the superuser credentials, but the schema updates to alter the RF of system_auth waits for the cassdc to reach Ready state to be applied.
Which issue(s) this PR fixes:
Fixes #1272
Checklist