-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medusa bucket secret label #1262
Conversation
A bunch of unit/integration test failures here, these don't happen locally so I'm not sure what the problem is. I'm assuming there's something wrong with main which is getting picked up in the pre-test rebase. EDIT: nope just a flake... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
- Coverage 57.43% 57.41% -0.03%
==========================================
Files 103 103
Lines 10808 10823 +15
==========================================
+ Hits 6208 6214 +6
- Misses 4063 4072 +9
Partials 537 537
|
…celled error on the .Patch call.
1026351
to
e71e35b
Compare
8539f67
to
2b69e44
Compare
This PR now
It should be ready to go now and CI should be 100% green. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup in the #955
What this PR does:
Which issue(s) this PR fixes:
Fixes #1253
Checklist