-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#1240 medusa pull secret ref #1241
Feature/#1240 medusa pull secret ref #1241
Conversation
…llSecrets at the standalone deployment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1241 +/- ##
==========================================
+ Coverage 57.43% 57.87% +0.43%
==========================================
Files 103 103
Lines 10808 10791 -17
==========================================
+ Hits 6208 6245 +37
+ Misses 4063 4011 -52
+ Partials 537 535 -2
|
Anyone liking to review this PR ? ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing this 👍
Hi @tuxBurner, your branches has some conflicts and can't make it into the release we're cutting out today. |
@adejanovski okay merge conflict is fixxed |
@adejanovski well now suddenly i get a failure on the Quality Gate check. But the Code was fine before 👍 Am i supposed to fix this or can I ignore it ? |
You can ignore it, no worries |
CHANGELOG/CHANGELOG-1.14.md
Outdated
@@ -23,3 +24,4 @@ When cutting a new release, update the `unreleased` heading to the tag being gen | |||
* [CHANGE] Update Medusa to v0.20.1 | |||
* [BUGFIX] [#1235](https://github.com/k8ssandra/k8ssandra-operator/issues/1235) Prevent operator from modifying the spec when superUserRef is not set. Also, remove the injection to mount secrets to cassandra container. | |||
* [BUGFIX] [#1239](https://github.com/k8ssandra/k8ssandra-operator/issues/1239) Use `concurrent_transfers` setting from MedusaConfiguration object if it is actually set. | |||
* [BUGFIX] [#1240](https://github.com/k8ssandra/k8ssandra-operator/issues/1240) The PullSecretRef for medusa is ignored in the standalone deployment of medusa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: 1.14.0 was released already and this line needs to go under a new ## unreleased
section to create above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay fixxed :)
Quality Gate passedIssues Measures |
🥳 thanks a lot |
Thank you for your contribution @tuxBurner! 🎉 |
What this PR does:
Which issue(s) this PR fixes:
Fixes #1240
Checklist